Skip to content

Conversation

@hammerlink
Copy link
Contributor

PR #1794 introduced a default --topo-order for the margin popup. This makes Neogit’s status view nearly unusable due to the cost of topological sorting on repos with a large commit history (like the kernel).

This PR adds a commit_order config option (default "topo") so users can override or disable the behavior (commit_order = ""). That restores fast refreshes while still allowing topological or date-based ordering when desired.

@CKolkey
Copy link
Member

CKolkey commented Sep 4, 2025

I'm not opposed to this, but when I try opening the kernel in neogit it opens quite quickly. How long does it take you to open?

@hammerlink
Copy link
Contributor Author

This is my workflow:

git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git neogit_test
cd neogit_test
echo hello > hello & git add hello
neovim
:Neogit

It takes me approximately 21 seconds before I can see the staged changes. Any subsequent change like git rm -f hello takes 21 seconds again before it is visible on the status page.

@CKolkey
Copy link
Member

CKolkey commented Sep 5, 2025

Well, that is objectively terrible 😮‍💨

If this helps you bring that time down, then I'll call that a win.

@CKolkey CKolkey merged commit 6617978 into NeogitOrg:master Sep 5, 2025
5 of 6 checks passed
@hammerlink
Copy link
Contributor Author

@CKolkey thanks!

@CKolkey
Copy link
Member

CKolkey commented Sep 6, 2025

@CKolkey thanks!

No worries! Thank you for the PR :)

@lucasadelino
Copy link
Contributor

This is my workflow:

git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git neogit_test
cd neogit_test
echo hello > hello & git add hello
neovim
:Neogit

It takes me approximately 21 seconds before I can see the staged changes. Any subsequent change like git rm -f hello takes 21 seconds again before it is visible on the status page.

Oof, sorry about the performance hit! Should have thought about allowing a config override. Thanks for adding it!

@hammerlink hammerlink deleted the feature/parameterize-commit-order branch September 12, 2025 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants